Skip to content

feature: enabled multi-line parsing of env files#49

Merged
bolorundurowb merged 2 commits intobolorundurowb:masterfrom
SamhammerAG:master
May 30, 2024
Merged

feature: enabled multi-line parsing of env files#49
bolorundurowb merged 2 commits intobolorundurowb:masterfrom
SamhammerAG:master

Conversation

@VijoPlays
Copy link
Contributor

@VijoPlays VijoPlays commented Mar 22, 2024

With this PR it should be possible to read an .env variable from a file with multiple lines.

One minor issue for the tests:

I can't seem to get the EnvReader to find the new env file I created for the tests. Would be nice if you could take a look and merge this in the next couple of days.

@bolorundurowb bolorundurowb changed the title fearture: Enabled multi-line parsing of env files feature: enabled multi-line parsing of env files May 30, 2024
@bolorundurowb bolorundurowb merged commit 7066ae3 into bolorundurowb:master May 30, 2024
@bolorundurowb
Copy link
Owner

Thanks @VijoPlays

@bolorundurowb
Copy link
Owner

This closes #29

@bolorundurowb
Copy link
Owner

@VijoPlays I have to revert this PR as the multi line reader doesnt work as expected and the test for it fails

@VijoPlays
Copy link
Contributor Author

@VijoPlays I have to revert this PR as the multi line reader doesnt work as expected and the test for it fails

@bolorundurowb yes, that's the issue I mentioned in the PR:

I can't seem to get the EnvReader to find the new env file I created for the tests. Would be nice if you could take a look and merge this in the next couple of days.

The reader itself behaves correctly, it's probably just a pathing error or something in the tests.

@VijoPlays
Copy link
Contributor Author

Reopened in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants