feature: enabled multi-line parsing of env files#49
Merged
bolorundurowb merged 2 commits intobolorundurowb:masterfrom May 30, 2024
Merged
feature: enabled multi-line parsing of env files#49bolorundurowb merged 2 commits intobolorundurowb:masterfrom
bolorundurowb merged 2 commits intobolorundurowb:masterfrom
Conversation
Owner
|
Thanks @VijoPlays |
Owner
|
This closes #29 |
Owner
|
@VijoPlays I have to revert this PR as the multi line reader doesnt work as expected and the test for it fails |
Contributor
Author
@bolorundurowb yes, that's the issue I mentioned in the PR:
The reader itself behaves correctly, it's probably just a pathing error or something in the tests. |
Contributor
Author
|
Reopened in #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR it should be possible to read an .env variable from a file with multiple lines.
One minor issue for the tests: