Add support for optarch=GENERIC. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Sep 26, 2020
EESSI-pilot-2020.09.sh
Outdated
|
|
||
| DETECTION_PARAMETERS='' | ||
| GENERIC=0 | ||
| EB='echo eb' |
EESSI-pilot-2020.09.sh
Outdated
| echo_yellow ">> GENERIC build requested, taking appropriate measures!" | ||
| DETECTION_PARAMETERS="$DESTINATION_PARAMETERS --generic" | ||
| GENERIC=1 | ||
| EB='echo eb --optarch=GENERIC' |
Owner
There was a problem hiding this comment.
echo should also be removed here?
EESSI-pilot-2020.09.sh
Outdated
| EB='echo eb' | ||
| if [[ "$1" == "--generic" || "$EASYBUILD_OPTARCH" == "GENERIC" ]]; then | ||
| echo_yellow ">> GENERIC build requested, taking appropriate measures!" | ||
| DETECTION_PARAMETERS="$DESTINATION_PARAMETERS --generic" |
Owner
There was a problem hiding this comment.
s/DESTINATION_PARAMETERS/DETECTION_PARAMETERS/?
Author
There was a problem hiding this comment.
This is what I get for using VIM on a remote host! :)
boegel
approved these changes
Sep 26, 2020
boegel
pushed a commit
that referenced
this pull request
Aug 27, 2021
let build script also define $EESSI_SOFTWAREPATH, so it can be used by hooks to inject RPATH override path
boegel
pushed a commit
that referenced
this pull request
Nov 9, 2022
move CPU arch specifications to separate spec files
boegel
pushed a commit
that referenced
this pull request
May 28, 2025
Sync with EESSI/software-layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now against the correct branch...