Skip to content

Drop -dynamic and -shared flags in favor of CRAYPE_LINK_TYPE=dynamic #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 2 commits into from
May 15, 2015
Merged

Drop -dynamic and -shared flags in favor of CRAYPE_LINK_TYPE=dynamic #9

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0373d6a
expose $CRAYPE_LINK_TYPE=dynamic in case of either shared or dynamic …
May 15, 2015
fbe5ada
Dropped tabs. Sry.
May 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions easybuild/toolchains/compiler/craype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ class CrayPECompiler(Compiler):
}

COMPILER_UNIQUE_OPTION_MAP = {
'shared': 'shared',
'dynamic': 'dynamic',
#handled shared and dynamic always via CRAYPE_LINK_TYPE environment variable, dont pass flags to wrapper.
Copy link
Owner

@boegel boegel May 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tabs please

'shared': '',
'dynamic': '',
Copy link
Owner

@boegel boegel May 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we just drop dynamic all together then? what's the use?

'static': 'static',
'verbose': 'craype-verbose',
'mpich-mt': 'craympich-mt',
Expand Down Expand Up @@ -117,7 +118,7 @@ def prepare(self, *args, **kwargs):
"""Prepare to use this toolchain; define $CRAYPE_LINK_TYPE if 'dynamic' toolchain option is enabled."""
super(CrayPECompiler, self).prepare(*args, **kwargs)

if self.options['dynamic']:
if self.options['dynamic'] or self.options['shared']:
env.setvar('CRAYPE_LINK_TYPE', 'dynamic')


Expand Down