Skip to content

Fix cross compile#999

Merged
IsaacWarren merged 2 commits intomainfrom
isaac/fix_cross_compile
Jan 7, 2026
Merged

Fix cross compile#999
IsaacWarren merged 2 commits intomainfrom
isaac/fix_cross_compile

Conversation

@IsaacWarren
Copy link
Contributor

Changes included in this PR

Fixes linux-aarch64 builds in conda-forge by allowing us to get pyarrow include and lib dirs without importing pyarrow (which cause the arrow_python shared object to be loaded, this is an issue because the architecture doesn't match the builder)

Testing strategy

Built on aws linux instance

User facing changes

Linux-aarch64 on conda-forge after release and conda-forge/bodo-feedstock#40 is merged

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.75%. Comparing base (c33fbb5) to head (a0da4aa).
⚠️ Report is 182 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
+ Coverage   66.68%   68.75%   +2.07%     
==========================================
  Files         186      195       +9     
  Lines       66795    67749     +954     
  Branches     9507     9643     +136     
==========================================
+ Hits        44543    46584    +2041     
+ Misses      19572    18324    -1248     
- Partials     2680     2841     +161     

@IsaacWarren
Copy link
Contributor Author

Release and Pip build passed as well

@IsaacWarren IsaacWarren marked this pull request as ready for review January 6, 2026 17:41
@IsaacWarren IsaacWarren changed the title Isaac/fix cross compile Fix cross compile Jan 6, 2026
Copy link
Collaborator

@ehsantn ehsantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IsaacWarren.

@IsaacWarren IsaacWarren merged commit 80aabbd into main Jan 7, 2026
77 of 78 checks passed
@IsaacWarren IsaacWarren deleted the isaac/fix_cross_compile branch January 7, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants