Skip to content

Support negative n in df.head()#972

Merged
ehsantn merged 1 commit intomainfrom
ehsan/df_neg_head
Dec 11, 2025
Merged

Support negative n in df.head()#972
ehsantn merged 1 commit intomainfrom
ehsan/df_neg_head

Conversation

@ehsantn
Copy link
Collaborator

@ehsantn ehsantn commented Dec 11, 2025

Changes included in this PR

As title. Fixes a Narwhals test.

Testing strategy

Narwhals test.

User facing changes

Negative n now works.

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@ehsantn ehsantn mentioned this pull request Dec 11, 2025
10 tasks
@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.71%. Comparing base (c33fbb5) to head (fbb18c7).
⚠️ Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   66.68%   67.71%   +1.02%     
==========================================
  Files         186      195       +9     
  Lines       66795    67683     +888     
  Branches     9507     9628     +121     
==========================================
+ Hits        44543    45829    +1286     
+ Misses      19572    19033     -539     
- Partials     2680     2821     +141     

@ehsantn
Copy link
Collaborator Author

ehsantn commented Dec 11, 2025

CI errors are just flakiness.

@ehsantn ehsantn merged commit 6ec2dc4 into main Dec 11, 2025
24 of 30 checks passed
@ehsantn ehsantn deleted the ehsan/df_neg_head branch December 11, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants