Skip to content

More fixes for narwhals tests.#937

Merged
DrTodd13 merged 22 commits intomainfrom
todd/narwhals_max
Nov 20, 2025
Merged

More fixes for narwhals tests.#937
DrTodd13 merged 22 commits intomainfrom
todd/narwhals_max

Conversation

@DrTodd13
Copy link
Collaborator

@DrTodd13 DrTodd13 commented Nov 19, 2025

Changes included in this PR

Bodo scalar and series min/max convert NA to NaN for appropriate types to match Pandas.
Support head with negative "n" values.

Testing strategy

run_ci

User facing changes

Head now support negative values of "n".

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.79%. Comparing base (c33fbb5) to head (b8009ab).
⚠️ Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
+ Coverage   66.68%   68.79%   +2.10%     
==========================================
  Files         186      195       +9     
  Lines       66795    67595     +800     
  Branches     9507     9602      +95     
==========================================
+ Hits        44543    46502    +1959     
+ Misses      19572    18265    -1307     
- Partials     2680     2828     +148     

Copy link
Collaborator

@ehsantn ehsantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrTodd13 .

Copy link
Contributor

@scott-routledge2 scott-routledge2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrTodd13 !

@DrTodd13 DrTodd13 merged commit 77f31e1 into main Nov 20, 2025
27 of 30 checks passed
@DrTodd13 DrTodd13 deleted the todd/narwhals_max branch November 20, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants