Expose pandas.Timestamp in bodo.pandas#922
Merged
scott-routledge2 merged 2 commits intomainfrom Nov 12, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #922 +/- ##
==========================================
+ Coverage 66.68% 68.78% +2.10%
==========================================
Files 186 195 +9
Lines 66795 67560 +765
Branches 9507 9594 +87
==========================================
+ Hits 44543 46472 +1929
+ Misses 19572 18258 -1314
- Partials 2680 2830 +150 |
DrTodd13
approved these changes
Nov 11, 2025
Collaborator
DrTodd13
left a comment
There was a problem hiding this comment.
Awesome simple fix! Thanks.
ehsantn
approved these changes
Nov 11, 2025
Collaborator
ehsantn
left a comment
There was a problem hiding this comment.
Thanks @scott-routledge2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Currently, everything not supported in the DataFrame library is wrapped with
fallback_wrapper. This creates issues for Timestamp (and potentially other scalar types):This PR just exposes the actual pandas.Timestamp type to Bodo DataFrames and can be extended to other scalars and types that are not performance critical as well.
Testing strategy
New unit tests added.
User facing changes
pd.Timestamp.now()works.pd.Timestamp(x)doesn't warn.Checklist
[run CI]in your commit message.