Fixes for test_unique narwhals test#920
Merged
scott-routledge2 merged 2 commits intomainfrom Nov 11, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 66.68% 68.79% +2.10%
==========================================
Files 186 195 +9
Lines 66795 67557 +762
Branches 9507 9594 +87
==========================================
+ Hits 44543 46474 +1931
+ Misses 19572 18251 -1321
- Partials 2680 2832 +152 |
Contributor
Author
|
The results don't seem to be deterministic with 3 workers. The original dataframe is: Edit: oh this could be related to how dataframes are evaluated. The correct result is either going to be (1, 7.0) or (3, 8.0) but if the columns are evaluated independently then that would explain the sometimes mismatch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
duplicatedin the JIT fallback pathTesting strategy
narwhals:
test_unique-- all params now passing, (keep="none" falls back to pandas)User facing changes
Checklist
[run CI]in your commit message.