Support TPC-H Q5 in BodoSQL C++ backend#886
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
+ Coverage 66.68% 68.91% +2.22%
==========================================
Files 186 192 +6
Lines 66795 67378 +583
Branches 9507 9564 +57
==========================================
+ Hits 44543 46432 +1889
+ Misses 19572 18120 -1452
- Partials 2680 2826 +146 |
DrTodd13
approved these changes
Oct 22, 2025
| operands = java_call.getOperands() | ||
| left = java_expr_to_python_expr(operands[0], input_plan) | ||
| right = java_expr_to_python_expr(operands[1], input_plan) | ||
| # Calciate may add more than 2 operand for the same binary operator |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Calciate may add more than 2 operand for the same binary operator | |
| # Calcite may add more than 2 operand for the same binary operator |
Collaborator
Author
There was a problem hiding this comment.
Will fix in follow up PR.
scott-routledge2
approved these changes
Oct 24, 2025
Contributor
scott-routledge2
left a comment
scott-routledge2
left a comment
There was a problem hiding this comment.
LGTM, thanks @ehsantn !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Fills gaps to run TPC-H Q5 end to end in the new BodoSQL C++ backend.
Testing strategy
Enabled Q5 unit test.
User facing changes
None (disabled).
Checklist
[run CI]in your commit message.