Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 66.68% 68.45% +1.77%
==========================================
Files 186 195 +9
Lines 66795 68060 +1265
Branches 9507 9706 +199
==========================================
+ Hits 44543 46593 +2050
+ Misses 19572 18605 -967
- Partials 2680 2862 +182 |
| def load_namespace_properties(self, namespace: str | Identifier) -> Properties: | ||
| raise NotImplementedError | ||
|
|
||
| def namespace_exists(self, namespace: str | Identifier) -> bool: |
There was a problem hiding this comment.
I wasn't sure if we can implement this method in some meaningful way since namespace in this context is just a directory and we aren't implementing similar methods like drop_namespace or list_namespaces. We have an implementation of create_namespace but is just does a noop.
IsaacWarren
left a comment
There was a problem hiding this comment.
Thanks Scott, I think we need to do this for our Snowflake and S3 Tables catalogs too, right?
Snowflake and S3 subclass MetaStoreCatalog, which already has an implementation of |
|
Looks like the azure-polaris rest catalog tests are hanging: Update: |
|
So the error in Nightly is an actual bug. Something changed with how Pyiceberg's file io handles paths in Azure filesystems so it can no longer resolve relative paths to the correct container. Edit: |
Changes included in this PR
Upgrade pyicberg test dependency to 0.11.0 and fix errors.
Adds
namespace_existsmethod to fix type errors (just raisesNotImplementedErrror)Testing strategy
PR CI and nightly Iceberg tests
User facing changes
Checklist
[run CI]in your commit message.