Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1010 +/- ##
==========================================
+ Coverage 66.68% 68.73% +2.04%
==========================================
Files 186 195 +9
Lines 66795 67834 +1039
Branches 9507 9668 +161
==========================================
+ Hits 44543 46623 +2080
+ Misses 19572 18357 -1215
- Partials 2680 2854 +174 |
| - fsspec >=2021.09 | ||
| - pyarrow =22.0 | ||
| - numba >=0.62,<0.64 | ||
| - mpich # [not win] |
There was a problem hiding this comment.
mpich should be added to run dependencies automatically (same with impi-devel & openmpi)
| python -u examples/Misc/misc_pi.py | ||
| if [[ "$(uname)" == "Darwin" ]]; then | ||
| # OpenMPI requires mpiexec on macOS CI. | ||
| mpiexec -n 1 python -u examples/Misc/misc_pi.py |
There was a problem hiding this comment.
Singleton init (i.e. calling spawn from outside of mpiexec) doesn't seem to be working on github CI runners (maybe a misconfiguration or openmpi bug), it's otherwise been working on the other machines tested so far.
|
Just noticed another issue which is when running When the program is run outside of Not sure if this is expected behavior for openmpi or could be the reason CI was behaving strangely. Would it make sense to ignore the value of |
ehsantn
left a comment
There was a problem hiding this comment.
Thanks @scott-routledge2! Looks good to me.
Changes included in this PR
Use OpenMPI for Mac builds to improve initialization times.
Testing strategy
Nightly tests (Run on Linux + openmpi)
https://dev.azure.com/bodo-inc/Bodo/_build/results?buildId=26270&view=results
Release CI
Benchmarking was done on my M2 macbook using the default pixi environment and a simple test program, TPCH SF10, and Taxi (40 million rows)
Results:
User facing changes
Checklist
[run CI]in your commit message.