Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
+ Coverage 66.68% 68.72% +2.03%
==========================================
Files 186 195 +9
Lines 66795 67830 +1035
Branches 9507 9667 +160
==========================================
+ Hits 44543 46615 +2072
+ Misses 19572 18364 -1208
- Partials 2680 2851 +171 |
DrTodd13
approved these changes
Jan 21, 2026
| out_arr = arr.apply(_conv_to_double) | ||
| # Workaround Int NA being passed as NaN | ||
| if arr.dtype == pd.Int64Dtype(): | ||
| out_arr = out_arr.map(lambda x: None if x == "nan" else x) |
Collaborator
There was a problem hiding this comment.
Double-check this. Not exactly sure what this is doing but bare "nan" seems weird. Could be np.nan or "np.nan"?
Collaborator
Author
There was a problem hiding this comment.
String representation of np.nan is "nan". The previous code converts values to strings.
scott-routledge2
approved these changes
Jan 21, 2026
Contributor
scott-routledge2
left a comment
scott-routledge2
left a comment
There was a problem hiding this comment.
LGTM, Thanks @ehsantn
| from pandas.core.internals.array_manager import SingleArrayManager | ||
| except ModuleNotFoundError: | ||
| # Pandas >= 3 does not have an array_manager module (uses BlockManager/SinglBlockManager). | ||
| class SingleArrayManager: |
Contributor
There was a problem hiding this comment.
Looks like SingleArrayManager is just being used for a type annotation, can we remove it?
Collaborator
Author
There was a problem hiding this comment.
Will do in the next PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Next set of changes for supporting upcoming Pandas 3.
Testing strategy
Existing tests.
User facing changes
None.
Checklist
[run CI]in your commit message.