About dialog mvvm rework #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old dialog and html layout file have been removed. The layout of the dialog panel is defined in the AboutDialogLayout.fxml located in the resources with its stylesheet. The AboutDialogController class takes care of the text initialization of any components in the layout. It also implements any methodes called from any component of the dialog panel.
4 tasks
boceckts
force-pushed
the
AboutDialogFX
branch
5 times, most recently
from
729c7ca to
9907d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are discussing internally which frameworks and techniques to use for JavaFX. This PR is a proposal of afterburner.fx and MVVM.
You can ignore it for the moment. But since you guys also have some experience using JavaFX, we would welcome your input and feedback.
Observations so far: