fix: Don’t leak STRIP_TRANSIENTS action#961
Merged
Merged
Conversation
Return error instead of crashing when the master receives an undefined action or an action without a `payload` field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#940 introduced an internal
STRIP_TRANSIENTSaction that strips error state from the final reducer output, so it can be used to trigger side effects. This action type was being included in the actions forwarded by the client to multiplayer transports. Because this action does not have apayloadfield, this caused the master to crash in various places were it assumed apayloadobject would be defined.This PR adds logic to ignore the
STRIP_TRANSIENTSobject when forwarding actions to multiplayer transports.For robustness, it also allows the master to gracefully handle cases where it receives an undefined
actionoraction.payloadas in theory crashing on undefined user input could be an attack vector.CC: @shaoster
Reported on Gitter by @kevinddchen