Fix custom plugins not available in events hooks. Add test.#932
Merged
Conversation
delucis
requested changes
Apr 25, 2021
delucis
left a comment
delucis
left a comment
Member
There was a problem hiding this comment.
Thanks @MathieuLoutre! I think we need to keep reverse (see comment), but otherwise this is great!
Contributor
Author
|
Great! I've added the |
delucis
approved these changes
Apr 26, 2021
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
master).This changes the order the plugins are flushed in to fix the problem mentioned in #910. It also adds a test to make sure it works.
This removes the additional reverse as it seemed necessary to separate PluginEvents from the rest (hence CORE_PLUGINS and DEFAULT_PLUGINS) to execute everything in the right order.