fix(reducer): Fix stateID increment & build deltalog on server only#817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #795
The move reducer currently increments
_stateIDbefore events (and other plugins) are processed, potentially resulting in deltalogs as follows:This was causing bugs on the client, because the next move might produce a deltalog like:
This is filtered out by the client because the
_stateIDis considered stale.This fix ensures that
_stateIDis only incremented after plugins run, so that log entries for a single action all share the same ID. For multiplayer clients, events aren’t run locally, so we can’t send an optimisticdeltaloghere, because the “automatic” events would now be filtered out, so instead,deltalogis now only produced on the master (for multiplayer clients).