Skip to content

fix: FlatFile.listGames filter#802

Merged
delucis merged 4 commits into
boardgameio:masterfrom
Pong420:pong420/flatfile
Sep 20, 2020
Merged

fix: FlatFile.listGames filter#802
delucis merged 4 commits into
boardgameio:masterfrom
Pong420:pong420/flatfile

Conversation

@Pong420
Copy link
Copy Markdown
Contributor

@Pong420 Pong420 commented Sep 13, 2020 •
edited
Loading

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@delucis
Copy link
Copy Markdown
Member

delucis commented Sep 19, 2020

@Pong420 Thanks for this! Is it ready for review?

@Pong420
Copy link
Copy Markdown
Contributor Author

Pong420 commented Sep 19, 2020

yes

delucis
delucis approved these changes Sep 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks again.

@delucis delucis merged commit 4bd283c into boardgameio:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pong420 @delucis