build: Exclude svelte from Rollup’s external module list#767
Merged
Conversation
Member
|
@delucis Taking a step back, what are we losing by keeping 'svelte' in |
Member
Author
|
Typescript support for consumers. Users would have to manually install Svelte so that its ambient type declaration for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #766
@nicolodavis I’ve found it a little tricky to test this, but looking through the bundle output, this removes the Svelte imports introduced in 0.39.15, and I could get a demo project to build. Sorry for all the false starts getting the Svelte–Typescript integration working, I’ve been learning the hard way to double check my work…