Skip to content

Resolves issue #711 - Fix restore in debug controls#712

Merged
delucis merged 1 commit into
boardgameio:masterfrom
SmileyJames:fix/debug-controls-restore
May 24, 2020
Merged

Resolves issue #711 - Fix restore in debug controls#712
delucis merged 1 commit into
boardgameio:masterfrom
SmileyJames:fix/debug-controls-restore

Conversation

@SmileyJames
Copy link
Copy Markdown
Contributor

@SmileyJames SmileyJames commented May 23, 2020

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

Fixes #711

As far as I know, can't expect Restore function from svlete file, so can't test that function. See issue for more.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out, @SmileyJames!

And yeah, we don’t have any tooling around Svelte yet and Typescript support seems to be only just developing as Svelte is relatively newer.

@delucis delucis merged commit 4d45ff1 into boardgameio:master May 24, 2020
@SmileyJames SmileyJames deleted the fix/debug-controls-restore branch May 25, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore in debug controls sets state to undefined - doesn't restore state

2 participants