Skip to content

Auto-add trailing slash to server only if needed#403

Merged
nicolodavis merged 3 commits into
boardgameio:masterfrom
jasonharrison:server-trailing-slash
May 19, 2019
Merged

Auto-add trailing slash to server only if needed#403
nicolodavis merged 3 commits into
boardgameio:masterfrom
jasonharrison:server-trailing-slash

Conversation

@jasonharrison
Copy link
Copy Markdown
Contributor

Auto-add trailing slash to server only if needed

I spent a ton of time trying to figure out why { server: 'http://bgioserver/' } wasn't working -- I didn't realize that BGIO added the trailing slash for me. Now BGIO will only add the trailing slash if it is necessary.

Checklist

  • Use a separate branch in your local repo (not master).
  • Test coverage is 100% (or you have a story for why it's ok).

@nicolodavis nicolodavis merged commit efece0c into boardgameio:master May 19, 2019
@jasonharrison jasonharrison deleted the server-trailing-slash branch May 21, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants