update _undo to reflect current ctx#393
Merged
Merged
Conversation
add tests for undo and redo of actions that change phase.
nicolodavis
reviewed
May 8, 2019
Member
nicolodavis
left a comment
nicolodavis
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
nicolodavis
approved these changes
May 9, 2019
nicolodavis
added a commit
that referenced
this pull request
Aug 18, 2019
This code was originally added to cover the situation where the
phase could change within a turn in an event like this:
move: (G, ctx) => {
ctx.events.endPhase();
}
We can no longer end the phase without also ending the turn, so
this code is not necessary.
Link to original issue:
#389
Link to previous fix that is undone in this commit:
#393
nicolodavis
added a commit
that referenced
this pull request
Sep 10, 2019
This code was originally added to cover the situation where the
phase could change within a turn in an event like this:
move: (G, ctx) => {
ctx.events.endPhase();
}
We can no longer end the phase without also ending the turn, so
this code is not necessary.
Link to original issue:
#389
Link to previous fix that is undone in this commit:
#393
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add tests for undo and redo of actions that change phase.
Checklist
master).