Upgrade Babel 7 by philihp · Pull Request #332 · boardgameio/boardgame.io

philihp · 2019-01-06T20:05:53Z

Yak shave to end all yak shaves

Upgrades to Babel 7
~~Upgrades Storybook~~
Upgrades Rollup and config, removing deprecated things
- Has a warning (!) postcss plugin: The onwrite hook used by plugin postcss is deprecated. The generateBundle hook should be used instead., which I believe may be fixed by this: fixed: no onwrite method in rollup version 0.60.7 egoist/rollup-plugin-postcss#113
Upgrades Firebase
Upgrades Webpack
Upgrades React

Tests run

nicolodavis · 2019-01-07T03:34:06Z

Awesome!

Can you take a look at the integration test (npm run test:integration)? Looks like it's failing (although the script itself is not reporting itself as failed, which I should fix).

Reference: https://semaphoreci.com/nicolodavis/boardgame-io/branches/pull-request-332/builds/1

nicolodavis · 2019-01-07T03:35:41Z

-    "babel-cli": "^6.26.0",
-    "babel-core": "^6.26.3",
+    "@storybook/react": "^4.1.4",
+    "ajv": "^6.6.2",


What is this dependency for?

Resolves this warning

npm WARN ajv-keywords@3.2.0 requires a peer of ajv@^6.0.0 but none is installed. You must install peer dependencies yourself.

It's a quick/easy fix to a known problem described in webpack/schema-utils#23 (comment) and npm/npm#19877 and npm/npm#19877 (comment)

philihp · 2019-01-07T17:31:08Z

Holding tight, npm run dev needs bumping too. Looks like babel-watch just got a version that supports 7, too.

philihp · 2019-01-11T20:27:39Z

Nevermind... babel-watch still doesn't support Babel 7 yet. I think I can accomplish the same thing though with nodemon or @babel/cli (which is already included)... but they don't play well when they have to compile things outside of their dir (e.g. module-resolver going to ../../packages). @nicolodavis any feelings/aversions toward creating an examples/react/package.json and putting the examples dependencies in that, similar to how examples/react-native has its own package.json?

Pros:

Removes A LOT of devDependencies from the root project (e.g. chess.js)
Removes need for babel-watch entirely.
module-resolver here now goes to ../../dist/ which is packaged with Babel and Rollup and what is ultimately distributed, instead of ../../package/ which is just built on-the-fly with Babel.

Cons:

When working on an example project, you don't have the convenience of being able to make a change to core/client. Maybe this is a good thing though? You can still make changes to the boardgame.io library and validate them with unit tests using npm run test:watch, perhaps not with an example app.

vdfdev · 2019-01-13T03:09:44Z

I am just afraid that not being able to validate with the example app will make our life harder to manually test features. And this is important specially for some browser-dependent features like drag and drop that I am developing now.

philihp · 2019-01-13T03:32:43Z

Could the drag-and-drop components be developed within /examples/react/, and then moved into /src/ui/ when they're more solidified?

vdfdev · 2019-01-13T03:46:48Z

Not really, because I am changing Token.js which is already included in /src/ui/... I could make a full new copy of the file and use that instead for development... That's a way.

I think the drag and drop should be mostly done now, but I just wonder that this might also happen for other features that are not very easily unit-testable.

vdfdev · 2019-01-13T03:47:30Z

But at the same time, I love TDD and I think that forcing people to look more into the tests and less into manually testing is a good thing. So I don't know, im just pointing the trade-offs here :)

philihp · 2019-01-13T06:32:13Z

Yep yep, it is a tradeoff for sure.

Quick question... are you using npm run storybook for developing the components?

nicolodavis · 2019-01-13T07:44:46Z

I use the examples a lot when developing to do quick sanity tests. I think it should still be possible to have a separate package.json with all the dev dependencies and also "symlink" the boardgame.io dependency to the code in the repo so that you can make changes and see them live, no?

Also, I don't think anyone uses storybook. I'm in favor of removing it altogether.

nicolodavis · 2019-01-13T07:45:51Z

Any thoughts about the Babel regenerator runtime error that you get when running the integration test?

nicolodavis · 2019-01-14T13:56:14Z

Removed storybook in f853da8.

philihp · 2019-01-15T07:23:04Z

Like symlinking the package into node_modules? Babel 7 no longer transpiles files in there by default... might take some more configuration.

babel/babel#8711 (comment)

https://babeljs.io/docs/en/v7-migration#config-lookup-changes

nicolodavis · 2019-01-15T07:34:58Z

I see. OK, then let's just keep the examples in the same package.json as the main project until we can figure out a way to split them and still retain the ability to see library changes in the examples automatically.

philihp · 2019-01-15T08:44:33Z

        "whatwg-fetch": "2.0.4"
      },
      "dependencies": {
-        "chokidar": {


this was weird.. it had the same hash as whatwg-fetch, too... responsible for the last 5 build fails.

would be great to see what @firebase/polyfill looked like for 0.3.3 and why this happened, but monorepos 🤷‍♂️

philihp · 2019-01-15T08:49:08Z

@nicolodavis integration test works now, that's a clever test... I like it. rollup.npm.js needed an option added.

philihp · 2019-01-15T08:51:10Z

I guess last remaining unsolved question is how to get the examples webapp to hot-reload changes to a package outside of its dir.

nicolodavis · 2019-01-15T14:07:59Z

Thanks @philihp!

Let's punt that to another PR. This is a good change to get in right now.

Made one change, which is to remove the async-to-generator altogether (which avoids all the regeneratorRuntime hassle and also results in a smaller bundle).

nicolodavis · 2019-01-15T14:35:51Z

      replace({
        'process.env.NODE_ENV': JSON.stringify('production'),
      }),
-      uglify(


Missed this. Why are we no longer minifying the code here?

I'm guessing you deleted this because it was generating some errors and forgot to add it back.
Added rollup-plugin-terser instead.

Ah yeah, I removed it to simplify things. At first it was having some errors so I upgraded it but then the config for it was broken. rollup-plugin-terser looks a better solution anyway, and zero config 💯

nicolodavis · 2019-01-15T16:05:55Z

Also, about npm run dev, I think we could use nodemon / babel-node as shown here: https://hackernoon.com/using-babel-7-with-node-7e401bc28b04

philihp · 2019-01-15T22:40:14Z

Thanks for the merge, the scope of this was starting to make me go crazy 🤕 . I'll take a stab at nodemon/babel-node. There's GOTTA to be a way to make this work.

philihp added 4 commits January 5, 2019 18:37

updates @storybook/react

a8e8a99

wip updates to babel/rollup

6598f76

rollup build updated

335d3b7

jest needs this to run

06201f7

nicolodavis reviewed Jan 7, 2019

View reviewed changes

Merge branch 'master' into pb--babel7-upgrade2

32825aa

remove storybook

7e3f147

installed

990fc76

philihp added 4 commits January 14, 2019 23:41

integration harness updated to what create-react-app will make

57cb3b6

include runtime helpers for whatever the hell rollup does

a44850a

npm install with latest npm

ef9b6b4

package-lock hashes

ebf8f43

philihp force-pushed the pb--babel7-upgrade2 branch from fac9854 to ebf8f43 Compare January 15, 2019 08:26

firebase updated

9fa9514

philihp commented Jan 15, 2019

View reviewed changes

exclude async-to-generator

e85a765

nicolodavis added 2 commits January 15, 2019 22:12

properly remove storybook

71db741

Merge branch 'master' into test

b61e70c

nicolodavis reviewed Jan 15, 2019

View reviewed changes

add rollup-plugin-terser

d36c532

nicolodavis approved these changes Jan 15, 2019

View reviewed changes

nicolodavis merged commit 1f71bbd into boardgameio:master Jan 15, 2019

Conversation

philihp commented Jan 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests run

Uh oh!

nicolodavis commented Jan 7, 2019

Uh oh!

nicolodavis Jan 7, 2019

Choose a reason for hiding this comment

Uh oh!

philihp Jan 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philihp commented Jan 7, 2019

Uh oh!

philihp commented Jan 11, 2019

Uh oh!

vdfdev commented Jan 13, 2019

Uh oh!

philihp commented Jan 13, 2019

Uh oh!

vdfdev commented Jan 13, 2019

Uh oh!

vdfdev commented Jan 13, 2019

Uh oh!

philihp commented Jan 13, 2019

Uh oh!

nicolodavis commented Jan 13, 2019

Uh oh!

nicolodavis commented Jan 13, 2019

Uh oh!

nicolodavis commented Jan 14, 2019

Uh oh!

philihp commented Jan 15, 2019

Uh oh!

nicolodavis commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philihp Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philihp commented Jan 15, 2019

Uh oh!

philihp commented Jan 15, 2019

Uh oh!

nicolodavis commented Jan 15, 2019

Uh oh!

nicolodavis Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

nicolodavis Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

philihp Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

nicolodavis commented Jan 15, 2019

Uh oh!

philihp commented Jan 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

philihp commented Jan 6, 2019 •

edited

Loading

philihp Jan 7, 2019 •

edited

Loading

nicolodavis commented Jan 15, 2019 •

edited

Loading

philihp Jan 15, 2019 •

edited

Loading