feat(debug): Add collapse on load & hide toggle button options#1040
Merged
Conversation
delucis
reviewed
Dec 22, 2021
delucis
left a comment
delucis
left a comment
Member
There was a problem hiding this comment.
Thanks for this @MathieuLoutre! Nice code and works well.
Maybe I’d just suggest slightly clearer naming for the options API?
Instead of hidePanel and hideButton, how about collapseOnLoad and hideToggleButton?
Contributor
Author
|
No problem, the new names are more explicit which is good. I updated across but also wrote better tests (hopefully). Let me know if anything needs to change. |
delucis
approved these changes
Dec 23, 2021
delucis
changed the title
Member
|
Perfect — those tests are a big improvement 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more options to debug panel as per #1039
Checklist
main).