Conversation
jedel1043
approved these changes
Aug 18, 2024
Member
jedel1043
left a comment
jedel1043
left a comment
There was a problem hiding this comment.
Looks good! Only found a typo which doesn't block merging this.
| Ok(result) | ||
| } | ||
|
|
||
| /// Creates a `TemporalFeild` from a `PartialDate`. |
Member
There was a problem hiding this comment.
Suggested change
| /// Creates a `TemporalFeild` from a `PartialDate`. | |
| /// Creates a `TemporalField` from a `PartialDate`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a patch for some things I found while doing some implementation of
temporal_rsin Boa.The things the PR addresses / patches
DateTime::from_date_and_timewithmethods weren't checking whether the partials were empty, which would not be valid. This update throws an early error if the partial provided is empty.TemporalFieldsfrom aPartialDate. Primarily, after doing the implementation, I don't think having aFrom<PartialDate> for TemporalFieldsis a good idea. We will still need it internally, but I'm now leaning more towards using the calendar to generate the fields from a partial. Something akin tocalendar::create_fields_from_partial_date(partial_date).