Add feature to force float64-representable durations#621
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Nov 11, 2025
Merged
Add feature to force float64-representable durations#621nekevss merged 1 commit intoboa-dev:mainfrom
nekevss merged 1 commit intoboa-dev:mainfrom
Conversation
Manishearth
commented
Nov 10, 2025
| #[test] | ||
| #[cfg_attr(not(feature = "float64_representable_durations"), should_panic)] | ||
| fn duration_float64_representable() { | ||
| // built-ins/Temporal/Duration/prototype/add/float64-representable-integer |
Contributor
Author
There was a problem hiding this comment.
I only added one of the tests, but we could add more.
Manishearth
force-pushed
the
f64-representable
branch
from
f16ab17 to
1861d66
Compare
nekevss
approved these changes
Nov 11, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
I guess this is the more accurate representation off the spec too.
Looks good to me.
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Nov 11, 2025
Uplifts boa-dev/temporal#621 Bug: 401065166 Change-Id: Iad750a4e3c93dd65c7b2b10ab7e3789f5cc877de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7142574 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1543294}
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Nov 11, 2025
Pulls in boa-dev/temporal#621, fixing some tests Bug: 401065166 Change-Id: I477a9c2d234dfa7ddbf8946d6fdd17a26a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7143539 Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Manish Goregaokar <manishearth@google.com> Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org> Cr-Commit-Position: refs/heads/main@{#103653}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
Uplifts boa-dev/temporal#621 Bug: 401065166 Change-Id: Iad750a4e3c93dd65c7b2b10ab7e3789f5cc877de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7142574 Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1543294} NOKEYCHECK=True GitOrigin-RevId: 9780fdf90293d02d5bb549794ddb03b8dc2d4122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #613