Skip to content

Fix comment and organization of TimeZone::zero #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Manishearth merged 2 commits into from
Sep 11, 2025
Merged

Fix comment and organization of TimeZone::zero #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d591d7
Fix comment and organization of TimeZone::zero
Manishearth Sep 11, 2025
a853910
Merge branch 'main' into capi-tz-zero
nekevss Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions temporal_capi/bindings/c/TimeZone.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions temporal_capi/bindings/cpp/temporal_rs/TimeZone.d.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions temporal_capi/bindings/cpp/temporal_rs/TimeZone.hpp
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 6 additions & 7 deletions temporal_capi/src/time_zone.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,21 +78,20 @@ pub mod ffi {
Box::new(Self(temporal_rs::TimeZone::utc()))
}

pub fn utc_with_provider<'p>(p: &Provider<'p>) -> Result<Box<Self>, TemporalError> {
Ok(Box::new(Self(with_provider!(p, |p| {
temporal_rs::TimeZone::utc_with_provider(p)
}))))
}

/// Create a TimeZone that represents +00:00
///
/// This is the only way to infallibly make a TimeZone without compiled_data,
/// and can be used as a fallback.
pub fn zero() -> Box<Self> {
// TODO merge signature with below
Box::new(Self(temporal_rs::TimeZone::UtcOffset(Default::default())))
}

pub fn utc_with_provider<'p>(p: &Provider<'p>) -> Result<Box<Self>, TemporalError> {
Ok(Box::new(Self(with_provider!(p, |p| {
temporal_rs::TimeZone::utc_with_provider(p)
}))))
}

#[allow(clippy::should_implement_trait)]
pub fn clone(&self) -> Box<TimeZone> {
Box::new(TimeZone(self.0))
Expand Down
Loading