Make errors Copy#528
Merged
Merged
Conversation
nekevss
approved these changes
Aug 29, 2025
Work towards boa-dev#409 This moves the TimeZoneProvider trait to the timezone_provider crate. There's a lot of stuff that gets moved as a result. Some important things to note: - TimeZoneProvider now operates on its own IsoDateTime type - TimeZoneProvider produces UtcOffsetSeconds, not UtcOffsets - the utils *mostly* got moved to timezone_provider::utils, but it's doc(hidden).
Manishearth
force-pushed
the
error-copy
branch
from
9042e18 to
d108f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the strategy somewhat discussed in unicode-org/icu4x#6904.
Previously, all allocated error messages from Temporal would not carry over FFI since we were reluctant to make the error type need a destructor.
TemporalError is now fully Copy, and can contain ICU4X/ixdtf errors. It is still converted to a string over FFI, which does not allocate. This leads to a minimal loss of information.