Add struct to encapsulate invariants of rounding increments#49
Merged
Add struct to encapsulate invariants of rounding increments#49
Conversation
jedel1043
added
C-enhancement
nekevss
approved these changes
Jun 2, 2024
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
One nit, but definitely always down for a better repr 😄
Member
|
Looks like this needs a rebase |
jedel1043
force-pushed
the
strict-rounding-increments
branch
from
5f9aa80 to
fc8762b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves a bit of memory on the parameter list (
Option<NonZeroU32>is 4 bytes, whileOption<f64>is 16 bytes).