Make TimeZone::identifier() infallible#399
Merged
nekevss merged 1 commit intoboa-dev:mainfrom Jul 6, 2025
Merged
Conversation
linusg
force-pushed
the
timezone-identifier-infallible
branch
from
1156dc2 to
1691c0f
Compare
nekevss
approved these changes
Jul 6, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
In general, looks good to me.
I've had some general caution about changes to TimeZone while the providers get worked on / stabilized. I believe this is fine long term with upcoming changes to TimeZone and TimeZoneProvider. FWIW, #291 is the tracking issue; and I'm now realizing that there may not be any central issue, but there is some discussion in #330.
Partially related to #245 too, so that's nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.