Prune dependencies of timezone_provider in normal mode, add depcheck#310
Merged
nekevss merged 2 commits intoboa-dev:mainfrom May 23, 2025
Merged
Prune dependencies of timezone_provider in normal mode, add depcheck#310nekevss merged 2 commits intoboa-dev:mainfrom
nekevss merged 2 commits intoboa-dev:mainfrom
Conversation
Manishearth
force-pushed
the
provider-deps
branch
2 times, most recently
from
c7ee348 to
49f0df3
Compare
Manishearth
commented
May 23, 2025
| ]; | ||
|
|
||
| pub const COMPILED_DEPS: &[&str] = &[ | ||
| "bytes", |
Contributor
Author
There was a problem hiding this comment.
None of these parser deps should be showing up here.
Manishearth
changed the title
Manishearth
force-pushed
the
provider-deps
branch
2 times, most recently
from
1ecc9cc to
5043427
Compare
Manishearth
force-pushed
the
provider-deps
branch
from
5043427 to
40402cf
Compare
nekevss
approved these changes
May 23, 2025
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
LGTM. Thank for looking into this and putting together the depcheck tool!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309