Skip to content

Implement ZonedDateTime's add and subtract methods#102

Merged
jedel1043 merged 17 commits intomainfrom
impl-more-zdt-methods
Nov 3, 2024
Merged

Implement ZonedDateTime's add and subtract methods#102
jedel1043 merged 17 commits intomainfrom
impl-more-zdt-methods

Conversation

@nekevss
Copy link
Copy Markdown
Member

@nekevss nekevss commented Oct 30, 2024

Re: title, depends on #99 and #100

This PR implements ZonedDateTime's add and subtract methods along with related TimeZone operations that were needed.

There is also one test to verify the results based off test262.

@nekevss nekevss marked this pull request as ready for review October 30, 2024 05:17
@nekevss nekevss force-pushed the support-windows-tzdb branch 3 times, most recently from cc457ba to 5eebe3c Compare October 31, 2024 20:16
@nekevss nekevss changed the base branch from support-windows-tzdb to main November 3, 2024 03:00
Copy link
Copy Markdown
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment thread src/components/tz.rs Outdated
@nekevss nekevss requested a review from jedel1043 November 3, 2024 14:44
@nekevss nekevss added C-enhancement New feature or request C-api Changes related to the public API labels Nov 3, 2024
Copy link
Copy Markdown
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me!

@jedel1043 jedel1043 merged commit 49c2f59 into main Nov 3, 2024
@jedel1043 jedel1043 deleted the impl-more-zdt-methods branch November 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-api Changes related to the public API C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants