Conversation
Member
|
Can we read the root |
Test262 conformance changes
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3291 +/- ##
==========================================
- Coverage 50.32% 50.21% -0.11%
==========================================
Files 436 436
Lines 42604 42691 +87
==========================================
Hits 21439 21439
- Misses 21165 21252 +87 ☔ View full report in Codecov by Sentry. |
Member
|
Second the idea regarding reading the version in the |
Member
Author
|
Will see how to do this this weekend :) |
Member
Author
|
@jedel1043, @nekevss this should be ready now :) |
nekevss
reviewed
Sep 23, 2023
Member
nekevss
left a comment
There was a problem hiding this comment.
Was double checking the run and noticed a deprecation warning. Maybe adjust it to use $GITHUB_OUTPUT?
Co-authored-by: Kevin <46825870+nekevss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is a follow-up of #3290.
It adds a test for the MSRV to the CI, so that we don't get similar issues in the future.