Skip to content

Conversation

@pythonberg1997
Copy link
Contributor

Description

This pr is to fix an error within post execution handler for bsc system transaction

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add system transaction check in collect_system_reward

Potential Impacts

  • add potential impacts for other components here
  • ...

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2024

Valgrind Results:

==6591== Cachegrind, a cache and branch-prediction profiler
==6591== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==6591== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==6591== Command: target/release/snailtracer
==6591== 
--6591-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.810981072s
==6591== 
==6591== I   refs:      427,738,261
==6591== I1  misses:          3,170
==6591== LLi misses:          2,833
==6591== I1  miss rate:        0.00%
==6591== LLi miss rate:        0.00%
==6591== 
==6591== D   refs:      204,083,477  (132,274,351 rd   + 71,809,126 wr)
==6591== D1  misses:        340,695  (    200,734 rd   +    139,961 wr)
==6591== LLd misses:        137,639  (      4,347 rd   +    133,292 wr)
==6591== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==6591== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==6591== 
==6591== LL refs:           343,865  (    203,904 rd   +    139,961 wr)
==6591== LL misses:         140,472  (      7,180 rd   +    133,292 wr)
==6591== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@unclezoro unclezoro added this pull request to the merge queue Aug 16, 2024
Merged via the queue into develop with commit 8deac3a Aug 16, 2024
pythonberg1997 added a commit that referenced this pull request Aug 23, 2024
fix: add system transaction check in `collect_system_reward` (#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants