Skip to content

fix: no such object error code #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2024
Merged

fix: no such object error code #1423

merged 3 commits into from
Jul 9, 2024

Conversation

@BarryTong65
Copy link
Contributor

@BarryTong65 BarryTong65 commented Jun 12, 2024 •
edited
Loading

Description

replace error code from 500 to 404 when object is not found

Rationale

"gater/object_handler.go:437","msg":"HttpStatusCode[500] action[GetObject] 
\"inner_code\":55001,\"description\":\"failed to get object info from consensus, 
error:rpc error: code = Unknown desc = No such object: unknown request\"

Example

add an example CLI or API response...

Changes

Notable changes:

  • replace error code from 500 to 404 when object is not found

Potential Impacts

  • QA

@BarryTong65 BarryTong65 merged commit b1060f1 into develop Jul 9, 2024
@BarryTong65 BarryTong65 deleted the fix-error-code branch July 9, 2024 02:35
This was referenced Jul 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruojunm ruojunm ruojunm approved these changes

@constwz constwz constwz approved these changes

@keefel keefel Awaiting requested review from keefel keefel is a code owner

+1 more reviewer

@mliu233 mliu233 mliu233 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BarryTong65 @mliu233 @ruojunm @constwz