[R4R] p2p: define DiscReason as uint8 #958
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other implementations store disconnect reasons as a single byte, so go-ethereum should do it too.
keefel
changed the title
forcodedancing
approved these changes
Jun 23, 2022
realuncle
approved these changes
Jun 23, 2022
unclezoro
approved these changes
Jun 23, 2022
brilliant-lx
approved these changes
Jun 23, 2022
This was referenced Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Define DiscReason as uint8, cherry-pick from ethereum/go-ethereum#24507, and fix CVE-2022-29177.
Rationale
All other implementations store disconnect reasons as a single byte, so bsc should do it too.
Example
NA
Changes
Notable changes: