BUG:pending snapshot block and state cannot update#893
Closed
lochjin wants to merge 1 commit intobnb-chain:masterfrom
Closed
BUG:pending snapshot block and state cannot update#893lochjin wants to merge 1 commit intobnb-chain:masterfrom
lochjin wants to merge 1 commit intobnb-chain:masterfrom
Conversation
Closed
Lippertt
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pending snapshot block and state cannot update when txs or block header is changed
Rationale
If the block environment required by EVM is not synchronized, the estimation of gas will be completely different from the actual use.
Example
EstimateGas -> StateAndHeaderByNumberOrHash -> miner.Pending()