BEP-466: Make the block header format compatible with EIP-7685 #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
RequestsHash should also be used to generate the signature of blocks, |
MatusKysel
reviewed
Nov 28, 2024
MatusKysel
previously approved these changes
Nov 28, 2024
zzzckck
previously approved these changes
Dec 2, 2024
Collaborator
zzzckck
left a comment
zzzckck
left a comment
There was a problem hiding this comment.
so far, LGTM, but need further update as Ethereum will remove requests from block body, BSC will do the same thing.
MatusKysel
previously approved these changes
Dec 2, 2024
buddh0
changed the title
setunapo
approved these changes
Dec 13, 2024
zzzckck
approved these changes
Dec 13, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BEP-466: Make the block header format compatible with EIP-7685
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: