Update network.py wtih get_digest method#106
Open
CodeDruidX wants to merge 1 commit intobmuller:masterfrom
Open
Update network.py wtih get_digest method#106CodeDruidX wants to merge 1 commit intobmuller:masterfrom
CodeDruidX wants to merge 1 commit intobmuller:masterfrom
Conversation
Add get_digest method
bmuller
reviewed
Mar 31, 2025
| self.ksize, self.alpha) | ||
| return await spider.find() | ||
|
|
||
| async def get_digest(self, dkey): |
Owner
There was a problem hiding this comment.
I think it would make most sense to remove lines 145 - 155 and replace them with a call to this method (so there isn't any unnecessary duplication).
bmuller
reviewed
Mar 31, 2025
| Returns: | ||
| :class:`None` if not found, the value otherwise. | ||
| """ | ||
| log.info("Looking up key %s", dkey) |
Owner
There was a problem hiding this comment.
Suggested change
| log.info("Looking up key %s", dkey) | |
| log.info("Looking up key digest %s", dkey) |
Owner
|
Are there cases where you know the digest but not the original key? If so - I'm happy to merge w/ the comments here addressed. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server node has an ability to set entry in DHT by its key digest representation, but cant get value with it.