Fix deprecated webrtcICEServers parser for IPv6 hosts; document address format#5906
Open
poeggi wants to merge 2 commits into
Open
Fix deprecated webrtcICEServers parser for IPv6 hosts; document address format#5906poeggi wants to merge 2 commits into
poeggi wants to merge 2 commits into
Conversation
strings.Split produces wrong part count when the host contains colons (IPv6). SplitN(s, ";", 4) keeps the hostport token intact.
poeggi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5905
What changes
Bug fix (
internal/conf/conf.go): the deprecatedwebrtcICEServersparser usedstrings.Splitand checked for exactly 5 parts. An IPv6 host contains extra colons, producing the wrong part count and silently dropping credentials. Fixed withstrings.SplitN(s, ":", 4)-- the hostport token is kept intact regardless of colons.Docs (
mediamtx.yml,docs/2-features/05-configuration.md): added an address format reference explaining the[host]:portform, what the empty-host default does on different platforms, and how to restrict to IPv4 only or bind to a specific interface. No address default values are changed.