chore: rename SELFDESTRUCT to SELFDESTRUCT_REFUND #2937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2937 will not alter performanceComparing Summary
|
rakita
reviewed
Sep 2, 2025
rakita
reviewed
Sep 2, 2025
rakita
approved these changes
Sep 2, 2025
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
makes sense, as it is a gas for refund. I have renamed it to SELFDESTRUCT_REFUND so that 'selfdestruct' is read first.
Co-authored-by: rakita <[email protected]>
Co-authored-by: rakita <[email protected]>
nkysg
changed the title
This was referenced Sep 5, 2025
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
go-ethereum, the nameSelfdestructRefundGasis used (https://github.com/ethereum/go-ethereum/blob/f3c696fa1db75d0f78ea47dd0975f6f0de6fdd84/params/protocol_params.go#L90).A more suitable name might be REFUND_SELFDESTRUCT. Feel free to close this.