Merged
Conversation
gndelia
requested review from
Copilot,
gabmontes,
leanazulyoro,
maxivarela and
mbonfoster
There was a problem hiding this comment.
Pull Request Overview
This PR revamps and updates the project dependencies and CI configuration while moving some configuration out of package.json.
- Replaces mocha with vitest and updates test syntax.
- Bumps ESLint-related dependencies and relocates config files.
- Adds a new knip configuration and updates CI actions to hemilabs/actions.
Reviewed Changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/eth-rpc-cache/test/index.spec.ts | Converts tests to vitest syntax and updates timer utilities. |
| packages/eth-rpc-cache/src/rpc.ts | Adjusts destructuring order in caching initialization. |
| packages/eth-rpc-cache/src/error.ts | Removes the export keyword on JsonRpcError, possibly affecting external use. |
| knip.config.js | Introduces a configuration file for knip dependency checks. |
| .github/workflows/js-checks.yml | Updates the CI configuration to integrate hemilabs actions. |
Files not reviewed (5)
- .eslintrc.json: Language not supported
- .github/workflows/CI_Checks.yml: Language not supported
- package.json: Language not supported
- packages/eth-rpc-cache/package.json: Language not supported
- packages/eth-rpc-cache/tsconfig.json: Language not supported
gabmontes
reviewed
Apr 28, 2025
gabmontes
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revamps a bit the lib, updating some of the dependencies, and moving the configs out of the package.json (partially, not completed).
It may be easier to review by commit:
mochawithvitest, which has better support for Typescript. This way, we can dropts-nodewhich was used only for its loadereslint-config-bloq. I fixed the eslint warnings, and moved the config out of thepackage.jsonknipand thedeps:checkscript. This detected an unused export, so I fixed it(No need to bump the version for this)