Support emitted event date on the logs list#3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
Adds support for displaying the emitted event date on the logs list on contract (address) and transaction views. When viewing logs in address context and the API provides
block_timestampfor a log entry, a "Timestamp" row is shown with the event time using the existingDetailedInfoTimestampcomponent.Proposed Changes
block_timestamp: string | nullto theLoginterface so the frontend can consume the field when the backend exposes it (see blockscout/blockscout#13572).type === 'address'and bothtransaction_hashandblock_timestampare present, render a "Timestamp" row withDetailedInfoTimestamp. No change for transaction view (single tx, so timestamp is redundant).block_timestampto the log stub for local/dev.block_timestampso the timestamp row is covered.Breaking or Incompatible Changes
None.
Additional Information
Backend support is tracked in blockscout/blockscout#13572. The UI is backward-compatible: when
block_timestampis missing or null, the timestamp row is not shown.Checklist for PR author