Skip to content

Advanced filter enhancements #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isstuev merged 1 commit into from
Nov 12, 2025
Merged

Advanced filter enhancements #3121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/api/advancedFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export type AdvancedFilterParams = {
token_contract_symbols_to_exclude?: Array<string>;
};

export const ADVANCED_FILTER_TYPES = [ 'coin_transfer', 'ERC-20', 'ERC-404', 'ERC-721', 'ERC-1155' ] as const;
export const ADVANCED_FILTER_TYPES = [ 'coin_transfer', 'ERC-20', 'ERC-404', 'ERC-721', 'ERC-1155', 'contract_creation', 'contract_interaction' ] as const;
export type AdvancedFilterType = typeof ADVANCED_FILTER_TYPES[number];

export const ADVANCED_FILTER_AGES = [ '1h', '24h', '7d', '1m', '3m', '6m' ] as const;
Expand Down
Binary file modified ...screenshots__/FilterByColumn.pw.tsx_dark-color-mode_type-filter-dark-mode-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ilter/__screenshots__/FilterByColumn.pw.tsx_default_type-filter-dark-mode-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 12 additions & 4 deletions ui/advancedFilter/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,19 +73,27 @@ export const ADVANCED_FILTER_TYPES = [
},
{
id: 'ERC-20',
name: 'ERC-20',
name: 'ERC-20 Transfer',
},
{
id: 'ERC-404',
name: ' ERC-404',
name: 'ERC-404 Transfer',
},
{
id: 'ERC-721',
name: 'ERC-721',
name: 'ERC-721 Transfer',
},
{
id: 'ERC-1155',
name: 'ERC-1155',
name: 'ERC-1155 Transfer',
},
{
id: 'contract_creation',
name: 'Contract Creation',
},
{
id: 'contract_interaction',
name: 'Contract Interaction',
},
] as const;

Expand Down
8 changes: 4 additions & 4 deletions ui/advancedFilter/filters/AssetFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ const AssetFilter = ({ value = [], handleFilterChange }: Props) => {
{ !searchTerm && currentValue.map((item, index) => (
<Flex key={ item.token.address_hash } alignItems="center">
<Select
size="sm"
value={ [ item.mode ] }
onValueChange={ handleModeSelectChange(index) }
collection={ collection }
placeholder="Select mode"
minW="105px"
defaultValue={ [ item.mode || 'include' ] }
onValueChange={ handleModeSelectChange(index) }
portalled={ false }
w="105px"
minW="105px"
mr={ 3 }
/>
<TokenEntity.default token={ item.token } noLink noCopy flexGrow={ 1 }/>
Expand Down
2 changes: 1 addition & 1 deletion ui/advancedFilter/filters/TypeFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const TypeFilter = ({ value = [ RESET_VALUE ], handleFilterChange }: Props) => {

return (
<TableColumnFilter
title="Type of transfer"
title="Transaction type"
isFilled={ !(currentValue.length === 1 && currentValue[0] === RESET_VALUE) }
isTouched={ !isEqual(currentValue.sort(), value.sort()) }
onFilter={ onFilter }
Expand Down
Loading