Skip to content

Add tests for empty input/column names in table definitions #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Add tests for empty input/column names in table definitions #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
706b8c4
Add test on the table name in the definition matching the file name
TimNooren Dec 15, 2022
ef1a03f
Refactor test_validate_json
TimNooren Dec 19, 2022
1dce075
Add jsonschema validation for abi.inputs and table.schema arrays
TimNooren Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions test_cases/schema/default_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,29 @@
"$id": "#root/parser/abi/inputs",
"title": "Inputs",
"type": "array",
"items": {
"type": "object",
"properties": {
"indexed": {
"type": "boolean"
},
"name": {
"type": "string",
"minLength": 1,
"description": "Cannot be empty. Use unnamedField0, unnamedField1, etc. as placeholders."
},
"internalType": {
"type": "string"
},
"type": {
"type": "string"
}
},
"required": [
"name",
"type"
]
},
"default": []
},
"name": {
Expand Down Expand Up @@ -123,6 +146,26 @@
"$id": "#root/table/schema",
"title": "Schema",
"type": "array",
"items": {
"type": "object",
"properties": {
"description": {
"type": "string"
},
"name": {
"type": "string",
"minLength": 1,
"description": "Cannot be empty. Use unnamedField0, unnamedField1, etc. as placeholders."
},
"type": {
"type": "string"
}
},
"required": [
"name",
"type"
]
},
"default": []
},
"table_description": {
Expand Down
31 changes: 14 additions & 17 deletions tests/test_validate_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,8 @@ def load_json_file(path):

def validate_json(filename):
"""REF: https://json-schema.org/ """
# Describe what kind of json you expect.
json_data = load_json_file(filename)

try:
jsonschema.validate(instance=json_data, schema=schema)
except jsonschema.exceptions.ValidationError as err:
err = f"Given JSON data is InValid for file {filename}: \n {str(err)}"
print(err)
return False, err

message = "Given JSON data is Valid"
return True, message
jsonschema.validate(instance=json_data, schema=schema)


def get_json_files_in_dir(dir):
Expand All @@ -50,22 +40,21 @@ def get_json_files_in_dir(dir):

@pytest.mark.parametrize("filename", pass_tests)
def test_correct_cases(filename):
valid, msg = validate_json(filename)
assert (valid == True)
validate_json(filename)


@pytest.mark.parametrize("filename", fail_tests)
def test_wrong_cases(filename):
valid, msg = validate_json(filename)
assert (valid == False)
with pytest.raises(jsonschema.exceptions.ValidationError):
validate_json(filename)


all_files = get_json_files_in_dir('./airflow/dags/resources/stages/parse/')


@pytest.mark.parametrize("filename", all_files)
def test_file(filename):
valid, msg = validate_json(filename)
assert (valid == True)
validate_json(filename)


@pytest.mark.parametrize("filename", all_files)
Expand All @@ -74,3 +63,11 @@ def test_dataset_name_is_correct(filename):
dataset_name = json_data.get('table', {}).get('dataset_name', None)
assert os.path.split(filename)[0].split("/")[-1] == dataset_name


@pytest.mark.parametrize("filename", all_files)
def test_table_name_is_correct(filename):
json_data = load_json_file(filename)
table_name = json_data.get('table', {}).get('table_name', None)
basename = os.path.basename(filename)
expected_table_name = basename.replace('.json', '')
assert expected_table_name == table_name