Skip to content

Implement WebGL shaders#17

Merged
bloc97 merged 6 commits intobloc97:masterfrom
neuwcodebox:feat-web
Aug 19, 2019
Merged

Implement WebGL shaders#17
bloc97 merged 6 commits intobloc97:masterfrom
neuwcodebox:feat-web

Conversation

@neuwcodebox
Copy link
Copy Markdown
Contributor

@neuwcodebox neuwcodebox commented Aug 17, 2019

Hello, This is WebGL implementation related to issue #7.
You can test on this site.
It can play videos too. (It's just to show possibility.)

Example

I recommend you click to enlarge.
Original vs x2
test
Original vs x3 (x2 and x1.5)
22

@neuwcodebox neuwcodebox marked this pull request as ready for review August 17, 2019 12:44
Copy link
Copy Markdown
Owner

@bloc97 bloc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to take a good look at it and make sure it is the same algorithm. Otherwise good work, at first glance since it doesn't look wrong.

Copy link
Copy Markdown
Owner

@bloc97 bloc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, however the default png used should be an image already existing in the /results/Upscale_Examples/ folder, preferably an image in the /1080p-2160p/Original/ subfolder.
Furthermore, to prevent any kind of possible copyright infringement, we request not including input.mp4 in this repository.

@neuwcodebox
Copy link
Copy Markdown
Contributor Author

neuwcodebox commented Aug 18, 2019

@bloc97
Thank you!
I will fix those and commit soon.

@neuwcodebox
Copy link
Copy Markdown
Contributor Author

Hi, @bloc97
I removed input.mp4 and replaced the default image.

Copy link
Copy Markdown
Owner

@bloc97 bloc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as an example for possible WebGL shader implementations.

@bloc97 bloc97 merged commit 88ab7e2 into bloc97:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants