Add handling for missing glyphs and utf16 surrogate pairs#1008
Merged
dlamkins merged 2 commits intoblish-hud:devfrom Feb 4, 2026
Merged
Add handling for missing glyphs and utf16 surrogate pairs#1008dlamkins merged 2 commits intoblish-hud:devfrom
dlamkins merged 2 commits intoblish-hud:devfrom
Conversation
This addresses some issues with TextInputBase by ensuring that when calculating cursor indexes we take into account both missing glyphs and correctly handle surrogate pair characters. closes blish-hud#950
dlamkins
approved these changes
Feb 4, 2026
Member
|
Works great and I also love that it corrects the boundary handling for double-clicking! Recording.2026-02-03.221303.mp4 |
greaka
approved these changes
Feb 4, 2026
dlamkins
added a commit
that referenced
this pull request
Feb 5, 2026
dlamkins
added a commit
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some issues with TextInputBase by ensuring that when calculating cursor indexes we take into account both missing glyphs and correctly handle surrogate pair characters.
closes #950
Discussion Reference
https://discord.com/channels/531175899588984842/536970543736291346/1163814521597591562
Is this a breaking change?
Ideally no, however this does change how certain parts of text selection and malformed utf16 is handled as part of the .Text property.