-
Notifications
You must be signed in to change notification settings - Fork 0
build(deps): Bump react-dom and @types/react-dom #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 19.1.1 to 19.2.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.0/packages/react-dom) Updates `@types/react-dom` from 19.1.7 to 19.2.2 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: "@types/react-dom" dependency-version: 19.2.2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Deploying blinklabs-vpn with
|
| Latest commit: |
15eb3da
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4c98525.blinklabs-vpn.pages.dev |
| Branch Preview URL: | https://dependabot-npm-and-yarn-mult-cmto.blinklabs-vpn.pages.dev |
Needs ReviewI recommend reviewing this upgrade before merging because React 19 introduces breaking changes that require Node.js 18 or newer, and the project currently lacks an explicit Node.js engine specification in package.json. While the codebase already uses modern React APIs (createRoot) and doesn't use deprecated patterns like propTypes or defaultProps, the Node.js version requirement is critical infrastructure change that needs verification. Additionally, the upgrade includes fixes for useDeferredValue, form submission crashes, and Hot Reload issues, but also comes with a medium severity security vulnerability (CVE-2018-6341) that was fixed in version 16.4.2 and should already be resolved in this version. The project should add an engines field to package.json specifying Node.js >= 18 to prevent deployment issues. What we checked
Dependency Usagereact-dom serves as the critical bridge between React components and the browser DOM across this VPN frontend application. The library is used in the main application entry point to bootstrap the entire React application using the modern concurrent rendering API, and is also integrated into the test infrastructure via @testing-library/react for component testing. Additionally, the build configuration explicitly separates react-dom into a dedicated vendor chunk for optimized bundle splitting and caching, indicating it's recognized as a foundational dependency throughout the application's architecture.
This code is initializing a React application by creating a root ReactDOM node where the entire application will be mounted and rendered into the DOM. Other Usages (1)These usages were analyzed but no breaking changes were detected: react-dom
Changesreact-dom upgraded with two breaking changes: Node.js 18+ is now required, and flat config becomes the default recommended preset (legacy config moved to
View 44 more changes
References (8)[1]: React dependency being upgraded to ^19.1.0, which requires Node.js 18 or newer Line 22 in 15eb3da
[2]: react-dom dependency being upgraded to ^19.2.0, introducing breaking changes Line 23 in 15eb3da
[3]: Missing 'engines' field to specify Node.js version requirement - project needs to declare Node.js >= 18 compatibility [4]: Application already uses modern createRoot API from react-dom/client, which is compatible with React 19 Line 2 in 15eb3da
[5]: Build configuration includes react-dom in vendor chunk, confirming it's a critical dependency Line 35 in 15eb3da
[6]: Breaking change: React 19.2.0 requires Node.js 18 or newer - deployment environments must be verified (source link) [7]: Official React 19 upgrade guide detailing breaking changes including propTypes removal and defaultProps deprecation - codebase does not use these deprecated patterns (source link) [8]: Version 19.2.0 includes bug fixes for useDeferredValue, form submission crashes, and Hot Reload stack overflow issues (source link) fossabot analyzed this PR using static analysis and dependency research. |
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 19.1.1 to 19.2.0Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
8618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)8bb7241Bump useEffectEvent to Canary (#34610)83c88adHandle fabric root level fragment with compareDocumentPosition (#34533)68f00c9Release Activity in Canary (#34374)3168e08[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)3434ff4Add scrollIntoView to fragment instances (#32814)Updates
@types/react-domfrom 19.1.7 to 19.2.2Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)