Skip to content

MB-62221: Fix buffer overflow #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhinavdangeti merged 1 commit into from
Jun 12, 2024
Merged

MB-62221: Fix buffer overflow #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions c_api/index_io_c_ex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
using faiss::Index;
using faiss::IndexBinary;

int faiss_write_index_buf(const FaissIndex* idx, size_t* size, unsigned char** buf) {
int faiss_write_index_buf(const FaissIndex* idx, size_t* size, uint8_t** buf) {
try {
faiss::VectorIOWriter writer;
faiss::write_index(reinterpret_cast<const Index*>(idx), &writer);
unsigned char* tempBuf = (unsigned char*)malloc((writer.data.size()) * sizeof(uint8_t));
uint8_t* tempBuf = (uint8_t*)malloc((writer.data.size()) * sizeof(uint8_t));
std::copy(writer.data.begin(), writer.data.end(), tempBuf);
*buf = tempBuf;
*size = writer.data.size();
Expand Down
4 changes: 2 additions & 2 deletions c_api/index_io_c_ex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ extern "C" {

/** Write index to buffer
*/
int faiss_write_index_buf(const FaissIndex* idx, size_t* buf_size, unsigned char** buf);
int faiss_write_index_buf(const FaissIndex* idx, size_t* buf_size, uint8_t** buf);

/** Read index from buffer
*/
int faiss_read_index_buf(const unsigned char* buf, size_t limit, int io_flags,
int faiss_read_index_buf(const uint8_t* buf, size_t limit, int io_flags,
FaissIndex** p_out);

#ifdef __cplusplus
Expand Down