fix duplicate file in queue#477
Open
mathieu-morchipont wants to merge 1 commit intobleenco:masterfrom
Open
Conversation
|
|
mathieu-morchipont
force-pushed
the
fix/duplicate_file_in_queue
branch
from
eac792c to
1e8d758
Compare
Kangarused
approved these changes
Dec 10, 2019
Kangarused
left a comment
Kangarused
left a comment
There was a problem hiding this comment.
I've also encountered this issue, this does fix the problem and I don't see any potential bugs that could result unless the subs array is set to null at some point in a future commit.
Kangarused
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I drop two files then I drop two others files when the first queue not started, the plugin upload two files first then four files because the files in the first queue are status UploadStatus.Queue