Add file-open command to file nodes #34
Conversation
- make treeDataProvider use vscode the findFiles function for searching
- read files and scan for tags asynchronously
|
After re-reading #3, I'm thinking the changes here don't implement that request. This change just opens the file when a tag is clicked in the tree, but it doesn't specifically "go to each of the occurrences of a tag in the file". I can add that as part of this PR or as follow-up, whichever you prefer. The functionality I have here does seem useful independent of the preferred "go to a specific line in the file". |
|
You're right. However, I would rather keep the pr as is and we can do another pr to get the outcome requested in #3. |
blakedietz
left a comment
blakedietz
left a comment
There was a problem hiding this comment.
Checked it out and tested it, everything works great.
| @@ -1,6 +1,5 @@ | |||
| import { debounce } from "debounce"; | |||
| import * as fs from "fs"; | |||
| import * as recursiveReadDir from "recursive-readdir"; | |||
There was a problem hiding this comment.
We'll need to pull this out of package.json but I'm not going to block your pr because of that.
* docs(vscode-logo): Adds logo for extension (#20) * docs(logo): Add logo * build(config.yml): Add release branch * feat(Sorting): Sort the tag tree by tag and file (#21) Sort the tag tree alphbetically first by tags, then by file. Resolves #11 * style(tag-tree-data-provider.ts): Add some space in the import statement * ci(config.yml): Add develop branch to trigger ci * fix(icon.png): Renames nested-tags-logo.png to icon.png * perf(tag-tree-data-provider.ts): Scan files asynchronously (#24) * Scan files asynchronously * Only include markdown files * docs(CHANGELOG.md): Automatically publish changes to CHANGELOG.md (#25) Automatically publish changes to CHANGELOG.md * feat(go to file): add file-open command to file nodes (#34) - make treeDataProvider use vscode the findFiles function for searching - read files and scan for tags asynchronously * build(recursive-readdir): Remove recursive-readdir as a dependency * ci(package.json): Change run order of the plugins for semantic release
2 participants
This change adds "jump to file" functionality when file nodes in the tag tree are clicked. The file is opened and focused if it isn't yet open in a tab, or just focused if it is already open in a tab.
I also made the following changes:
I haven't yet added tests around the change(s). There don't seem to be existing cases around the class I touched, so maybe that's fine for now.